Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1399763002: Fix gpu drawBitmap to work when BM is A8 and we have a shader (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix gpu drawBitmap to work when BM is A8 and we have a shader BUG=skia: Committed: https://skia.googlesource.com/skia/+/79da63fa0bec40b560597c79c2e1231fa51aef36

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fixes #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 2 4 chunks +37 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
5 years, 2 months ago (2015-10-09 16:00:59 UTC) #2
bsalomon
https://codereview.chromium.org/1399763002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1399763002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1306 src/gpu/SkGpuDevice.cpp:1306: if (kAlpha_8_SkColorType == bitmap.colorType() && paint.getShader()) { Could use ...
5 years, 2 months ago (2015-10-09 17:07:09 UTC) #3
egdaniel
https://codereview.chromium.org/1399763002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1399763002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1306 src/gpu/SkGpuDevice.cpp:1306: if (kAlpha_8_SkColorType == bitmap.colorType() && paint.getShader()) { On 2015/10/09 ...
5 years, 2 months ago (2015-10-09 17:20:26 UTC) #4
bsalomon
lgtm
5 years, 2 months ago (2015-10-09 17:23:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399763002/40001
5 years, 2 months ago (2015-10-09 17:48:19 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 17:55:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/79da63fa0bec40b560597c79c2e1231fa51aef36

Powered by Google App Engine
This is Rietveld 408576698