Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: src/log.h

Issue 139973004: A64: Synchronize with r15814. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index bb3dbd5956e10594300899874714b128f0215bb8..194ad9d015898f75f1044371a290a1501873fb9d 100644
--- a/src/log.h
+++ b/src/log.h
@@ -31,7 +31,6 @@
#include "allocation.h"
#include "objects.h"
#include "platform.h"
-#include "log-utils.h"
namespace v8 {
namespace internal {
@@ -71,15 +70,16 @@ namespace internal {
// tick profiler requires code events, so --prof implies --log-code.
// Forward declarations.
-class LogMessageBuilder;
+class CodeAddressMap;
+class CompilationInfo;
+class CpuProfiler;
+class Isolate;
+class Log;
+class PositionsRecorder;
class Profiler;
class Semaphore;
-struct TickSample;
class Ticker;
-class Isolate;
-class PositionsRecorder;
-class CpuProfiler;
-class CompilationInfo;
+struct TickSample;
#undef LOG
#define LOG(isolate, Call) \
@@ -151,6 +151,7 @@ class CompilationInfo;
// original tags when writing to the log.
+class JitLogger;
class LowLevelLogger;
class Sampler;
@@ -337,12 +338,8 @@ class Logger {
return logging_nesting_ > 0;
}
- bool is_code_event_handler_enabled() {
- return code_event_handler_ != NULL;
- }
-
bool is_logging_code_events() {
- return is_logging() || code_event_handler_ != NULL;
+ return is_logging() || jit_logger_ != NULL;
}
// Pause/Resume collection of profiling data.
@@ -377,25 +374,9 @@ class Logger {
void LogFailure();
private:
- class NameBuffer;
- class NameMap;
-
explicit Logger(Isolate* isolate);
~Logger();
- // Issue code notifications.
- void IssueCodeAddedEvent(Code* code,
- Script* script,
- const char* name,
- size_t name_len);
- void IssueCodeMovedEvent(Address from, Address to);
- void IssueCodeRemovedEvent(Address from);
- void IssueAddCodeLinePosInfoEvent(void* jit_handler_data,
- int pc_offset,
- int position,
- JitCodeEvent::PositionType position_Type);
- void* IssueStartCodePosInfoEvent();
- void IssueEndCodePosInfoEvent(Code* code, void* jit_handler_data);
// Emits the profiler's first message.
void ProfilerBeginEvent();
@@ -407,9 +388,6 @@ class Logger {
// Internal configurable move event.
void MoveEventInternal(LogEventsAndTags event, Address from, Address to);
- // Internal configurable move event.
- void DeleteEventInternal(LogEventsAndTags event, Address from);
-
// Emits the source code of a regexp. Used by regexp events.
void LogRegExpSource(Handle<JSRegExp> regexp);
@@ -419,20 +397,6 @@ class Logger {
// Helper method. It resets name_buffer_ and add tag name into it.
void InitNameBuffer(LogEventsAndTags tag);
- // Helper method. It push recorded buffer into different handlers.
- void LogRecordedBuffer(Code*, SharedFunctionInfo*);
-
- // Helper method. It dumps name into name_buffer_.
- void AppendName(Name* name);
-
- // Appends standard code header.
- void AppendCodeCreateHeader(LogMessageBuilder*, LogEventsAndTags, Code*);
-
- // Appends symbol for the name.
- void AppendSymbolName(LogMessageBuilder*, Symbol*);
-
- void RegisterSnapshotCodeName(Code* code, const char* name, int name_size);
-
// Emits a profiler tick event. Used by the profiler thread.
void TickEvent(TickSample* sample, bool overflow);
@@ -462,7 +426,6 @@ class Logger {
// private members.
friend class EventLog;
friend class Isolate;
- friend class LogMessageBuilder;
friend class TimeLog;
friend class Profiler;
template <StateTag Tag> friend class VMState;
@@ -475,18 +438,13 @@ class Logger {
Log* log_;
LowLevelLogger* ll_logger_;
-
- NameBuffer* name_buffer_;
-
- NameMap* address_to_name_map_;
+ JitLogger* jit_logger_;
+ CodeAddressMap* code_address_map_;
// Guards against multiple calls to TearDown() that can happen in some tests.
// 'true' between SetUp() and TearDown().
bool is_initialized_;
- // The code event handler - if any.
- JitCodeEventHandler code_event_handler_;
-
// Support for 'incremental addresses' in compressed logs:
// LogMessageBuilder::AppendAddress(Address addr)
Address last_address_;
« no previous file with comments | « src/isolate.cc ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698