Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1399713002: Connection info popup overlapped with cetificate page info. (Closed)

Created:
5 years, 2 months ago by abhi.rathore
Modified:
5 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews, vivekg_samsung, Abhishek, Jitu( very slow this week)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Connection info popup overlapped with cetificate page info. For some of the website exmaple "yahoo.com", connection info popup got overlapped with certificate page due large content size of connection poup info. BUG=541538 Committed: https://crrev.com/99f877a9ddad6d6b3f836480b4be06cfb18a6059 Cr-Commit-Position: refs/heads/master@{#353688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/CertificateViewer.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
abhi.rathore
PTAL
5 years, 2 months ago (2015-10-09 11:18:42 UTC) #2
Yaron
yfriedman->newt
5 years, 2 months ago (2015-10-09 17:36:33 UTC) #4
newt (away)
Could you upload a screenshot to the bug showing how the UI looks with your ...
5 years, 2 months ago (2015-10-09 19:40:59 UTC) #5
abhi.rathore
On 2015/10/09 19:40:59, newt wrote: > Could you upload a screenshot to the bug showing ...
5 years, 2 months ago (2015-10-12 05:48:55 UTC) #6
newt (away)
lgtm thanks for fixing :)
5 years, 2 months ago (2015-10-12 15:50:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399713002/1
5 years, 2 months ago (2015-10-13 05:36:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 06:17:26 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 06:18:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99f877a9ddad6d6b3f836480b4be06cfb18a6059
Cr-Commit-Position: refs/heads/master@{#353688}

Powered by Google App Engine
This is Rietveld 408576698