Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3032)

Unified Diff: chrome/common/extensions/features/base_feature_provider.h

Issue 13997002: Load extensions features file separately when needed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix merge conflicts Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/base_feature_provider.h
diff --git a/chrome/common/extensions/features/base_feature_provider.h b/chrome/common/extensions/features/base_feature_provider.h
index 389f8acb0649b3b899743923de0e2e07cd82046b..c7289434a0c3f0d3dcab9540e4c9a4cad4a9106a 100644
--- a/chrome/common/extensions/features/base_feature_provider.h
+++ b/chrome/common/extensions/features/base_feature_provider.h
@@ -26,24 +26,15 @@ class BaseFeatureProvider : public FeatureProvider {
BaseFeatureProvider(const DictionaryValue& root, FeatureFactory factory);
virtual ~BaseFeatureProvider();
- // Gets an instance for the _api_features.json file that is baked into
- // Chrome as a resource.
- static BaseFeatureProvider* GetAPIFeatures();
+ // Gets a feature provider for a specific feature type, like "permission".
+ static FeatureProvider* GetByName(const std::string& name);
- // Gets an instance for the _manifest_features.json file that is baked into
- // Chrome as a resource.
- static BaseFeatureProvider* GetManifestFeatures();
-
- // Gets an instance for the _permission_features.json file that is baked into
- // Chrome as a resource.
- static BaseFeatureProvider* GetPermissionFeatures();
-
- // Returns all features described by this instance.
- std::set<std::string> GetAllFeatureNames() const;
// Gets the feature |feature_name|, if it exists.
virtual Feature* GetFeature(const std::string& feature_name) OVERRIDE;
+ virtual std::set<std::string> GetAllFeatureNames() OVERRIDE;
+
private:
typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
FeatureMap features_;
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698