chrome/common/extensions/features/base_feature_provider_unittest.cc - Issue 13997002: Load extensions features file separately when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/base_feature_provider_unittest.cc

Issue 13997002: Load extensions features file separately when needed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/base_feature_provider.cc ('K') | « chrome/common/extensions/features/base_feature_provider.cc ('k') | chrome/common/extensions/manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/base_feature_provider_unittest.cc

diff --git a/chrome/common/extensions/features/base_feature_provider_unittest.cc b/chrome/common/extensions/features/base_feature_provider_unittest.cc

index df876dc88c308106d9fd77d668e180aba12f118d..75cee73a233e3e85bf99052c5355d7ce2397388e 100644

--- a/chrome/common/extensions/features/base_feature_provider_unittest.cc

+++ b/chrome/common/extensions/features/base_feature_provider_unittest.cc

@@ -20,7 +20,7 @@ using extensions::SimpleFeature;

TEST(BaseFeatureProvider, ManifestFeatures) {

BaseFeatureProvider* provider =

- BaseFeatureProvider::GetManifestFeatures();

+ BaseFeatureProvider::GetFeaturesByName("manifest");

SimpleFeature* feature =

static_cast<SimpleFeature*>(provider->GetFeature("description"));

ASSERT_TRUE(feature);

@@ -62,7 +62,7 @@ TEST(BaseFeatureProvider, ManifestFeatures) {

TEST(BaseFeatureProvider, PermissionFeatures) {

BaseFeatureProvider* provider =

- BaseFeatureProvider::GetPermissionFeatures();

+ BaseFeatureProvider::GetFeaturesByName("permission");

SimpleFeature* feature =

static_cast<SimpleFeature*>(provider->GetFeature("contextMenus"));

ASSERT_TRUE(feature);