Emit better error message about writable properties

Emit better error message about writable properties

Section 8.10.5 9a specifies that a property descriptor cannot both have
accessors and specify the writability of the property. The previous
error message was misleading because it referred to writable rather
than specifying the writability (which includes writable: false).

BUG=v8:2536
LOG=N

Committed: https://crrev.com/8ed0454332beae12e7ff1704530500f342048c71
Cr-Commit-Position: refs/heads/master@{#31273}

[Franziska, 2015-10-10 06:42:58]

franziska.hinkelmann@gmail.com changed reviewers:
+ machenbach@chromium.org, rossberg@chromium.org

[Franziska, 2015-10-10 06:47:43]

The CQ bit was checked by franziska.hinkelmann@gmail.com

[Franziska, 2015-10-10 06:47:44]

The CQ bit was unchecked by franziska.hinkelmann@gmail.com

[Michael Achenbach, 2015-10-12 07:44:40]

machenbach@chromium.org changed reviewers:
+ yangguo@chromium.org

[Michael Achenbach, 2015-10-12 07:44:41]

+yang

[rossberg, 2015-10-12 09:00:14]

https://codereview.chromium.org/1399693003/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/1399693003/diff/1/src/messages.h#newcode239
src/messages.h:239: "accessors and specify the value or writability of the
property, %")       \
The test seems a bit redundant now. Can we simplify this to

"Invalid property descriptor: cannot both specify accessors and a value or
writable attribute, %"

[Yang, 2015-10-13 06:37:23]

On 2015/10/12 09:00:14, rossberg wrote:
> https://codereview.chromium.org/1399693003/diff/1/src/messages.h
> File src/messages.h (right):
> 
> https://codereview.chromium.org/1399693003/diff/1/src/messages.h#newcode239
> src/messages.h:239: "accessors and specify the value or writability of the
> property, %")       \
> The test seems a bit redundant now. Can we simplify this to
> 
> "Invalid property descriptor: cannot both specify accessors and a value or
> writable attribute, %"

Either case we got failing tests.

[Franziska, 2015-10-13 19:25:27]

I simplified the error message as suggested.

[rossberg, 2015-10-14 11:28:56]

lgtm

[Franziska, 2015-10-14 18:53:48]

The CQ bit was checked by franziska.hinkelmann@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-14 18:54:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399693003/40001

[commit-bot: I haz the power, 2015-10-14 19:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 19:19:09]

Dry run: This issue passed the CQ dry run.

[Franziska, 2015-10-14 19:20:47]

The CQ bit was unchecked by franziska.hinkelmann@gmail.com

[Franziska, 2015-10-14 19:20:49]

The CQ bit was checked by franziska.hinkelmann@gmail.com

[Franziska, 2015-10-14 19:20:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1399693003/#ps40001
(title: "Rebase onto newer source")

[commit-bot: I haz the power, 2015-10-14 19:21:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399693003/40001

[commit-bot: I haz the power, 2015-10-14 19:22:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-14 19:22:37]

Patchset 3 (id:??) landed as
https://crrev.com/8ed0454332beae12e7ff1704530500f342048c71
Cr-Commit-Position: refs/heads/master@{#31273}