Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 139963002: Call el.offsetHeight; to force update of computed style. (Closed)

Created:
6 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 11 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, arv+watch_chromium.org, dstockwell
Visibility:
Public.

Description

Call el.offsetHeight; to force update of computed style. Transitions does not work if change is 'auto' -> '0'. As work around code sets height to offsetHeight before changing height to '0'. However Blink still uses computed style and does not starts transition. So we have to call el.offsetHeight to force update computed style. Removed unused argument from onFadeOutTransitionEnd. BUG=330604 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245280

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/resources/print_preview/print_preview_animations.js View 2 chunks +3 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 11 months ago (2014-01-15 20:35:51 UTC) #1
Noam Samuel
lgtm https://codereview.chromium.org/139963002/diff/1/chrome/browser/resources/print_preview/print_preview_animations.js File chrome/browser/resources/print_preview/print_preview_animations.js (right): https://codereview.chromium.org/139963002/diff/1/chrome/browser/resources/print_preview/print_preview_animations.js#newcode67 chrome/browser/resources/print_preview/print_preview_animations.js:67: el.offsetHeight; // Should force an update of the ...
6 years, 11 months ago (2014-01-15 22:08:44 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2014/01/15 22:08:44, Noam Samuel wrote: > lgtm > > https://codereview.chromium.org/139963002/diff/1/chrome/browser/resources/print_preview/print_preview_animations.js > File chrome/browser/resources/print_preview/print_preview_animations.js (right): ...
6 years, 11 months ago (2014-01-15 22:13:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/139963002/1
6 years, 11 months ago (2014-01-15 22:17:20 UTC) #4
Noam Samuel
On 2014/01/15 22:13:54, Vitaly Buka wrote: > On 2014/01/15 22:08:44, Noam Samuel wrote: > > ...
6 years, 11 months ago (2014-01-15 22:19:24 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 19:32:12 UTC) #6
Message was sent while issue was closed.
Change committed as 245280

Powered by Google App Engine
This is Rietveld 408576698