third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp - Issue 1399623003: bluetooth: Change BluetoothSupplement::from(ScriptState*) to from(LocalFrame*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp

Issue 1399623003: bluetooth: Change BluetoothSupplement::from(ScriptState*) to from(LocalFrame*) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Add assert for supplement and changed to use executionContext Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp

index a0afc007d0338f009bfff4a10ebddb6b96d14a53..bdcfe907952c7acf0b3b508bacb238b6fe3d3232 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTService.cpp

@@ -34,7 +34,7 @@ BluetoothGATTService* BluetoothGATTService::take(ScriptPromiseResolver*, PassOwn

ScriptPromise BluetoothGATTService::getCharacteristic(ScriptState* scriptState,

const StringOrUnsignedLong& characteristic, ExceptionState& exceptionState)

{

- WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);

+ WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);

String characteristicUUID = BluetoothUUID::getCharacteristic(characteristic, exceptionState);

if (exceptionState.hadException())