third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp - Issue 1399623003: bluetooth: Change BluetoothSupplement::from(ScriptState*) to from(LocalFrame*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

Issue 1399623003: bluetooth: Change BluetoothSupplement::from(ScriptState*) to from(LocalFrame*) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Add assert for supplement and changed to use executionContext Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

index 1627bbf86c6766cfdad4791a89cd64c151f9f436..0e1f50a187aafb8e1519f77d97d9f17a4d637d88 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

@@ -32,7 +32,7 @@ BluetoothGATTCharacteristic* BluetoothGATTCharacteristic::take(ScriptPromiseReso

ScriptPromise BluetoothGATTCharacteristic::readValue(ScriptState* scriptState)

{

- WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);

+ WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

@@ -43,7 +43,7 @@ ScriptPromise BluetoothGATTCharacteristic::readValue(ScriptState* scriptState)

ScriptPromise BluetoothGATTCharacteristic::writeValue(ScriptState* scriptState, const DOMArrayPiece& value)

{

- WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);

+ WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);

// Partial implementation of writeValue algorithm:

// https://webbluetoothchrome.github.io/web-bluetooth/#dom-bluetoothgattcharacteristic-writevalue