third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp - Issue 1399623003: bluetooth: Change BluetoothSupplement::from(ScriptState*) to from(LocalFrame*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

Issue 1399623003: bluetooth: Change BluetoothSupplement::from(ScriptState*) to from(LocalFrame*) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Add assert for supplement and changed to use executionContext Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

index 421002cb8a190ab1c7ddbe93a67719a68955cc66..2a0bee72f892edaa8c5efc9123b3ecd4e13d742b 100644

--- a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

@@ -64,7 +64,7 @@ ScriptPromise Bluetooth::requestDevice(ScriptState* scriptState, const RequestDe

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(SecurityError, "Must be handling a user gesture to show a permission request."));

}

- WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);

+ WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);

if (!webbluetooth)

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError));