Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: android_webview/java/src/org/chromium/android_webview/FullScreenView.java

Issue 1399613002: Public glue layer plumbing for View#startActivityForResult (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/FullScreenView.java
diff --git a/android_webview/java/src/org/chromium/android_webview/FullScreenView.java b/android_webview/java/src/org/chromium/android_webview/FullScreenView.java
index 1eb96a4eda3dd97c99e511031b4607bcfac1b2dd..b25347e99f7d2941153d93348b4db0296bc0bd82 100644
--- a/android_webview/java/src/org/chromium/android_webview/FullScreenView.java
+++ b/android_webview/java/src/org/chromium/android_webview/FullScreenView.java
@@ -5,6 +5,7 @@
package org.chromium.android_webview;
import android.content.Context;
+import android.content.Intent;
import android.content.res.Configuration;
import android.graphics.Canvas;
import android.graphics.Paint;
@@ -230,6 +231,13 @@ public class FullScreenView extends FrameLayout {
}
@Override
+ public void super_startActivityForResult(Intent intent, int requestCode) {
sgurun-gerrit only 2015/10/16 00:06:53 I think you should call FullScreenView.super.start
hush (inactive) 2015/10/20 23:16:10 We discussed this bit offline. Just recap here: Th
+ // Intentional no-op. startActivityForResult will only go through
+ // the initial InternalAccessDelegate, which fires the intent
+ // through WebView.
+ }
+
+ @Override
public boolean awakenScrollBars() {
return FullScreenView.this.awakenScrollBars(0);
}

Powered by Google App Engine
This is Rietveld 408576698