Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1399543004: Cleanup after M (Closed)

Created:
5 years, 2 months ago by sgurun-gerrit only
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup after M Remove the reference to preview_sources from GN build file. Once this lands, next step is removing the actual source file from android_tools. BUG=512264 Committed: https://crrev.com/7c8e7090a85c023084b130f1c1a666fa93aeb151 Cr-Commit-Position: refs/heads/master@{#353925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sgurun-gerrit only
On 2015/10/13 22:23:21, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ptal, thanks
5 years, 2 months ago (2015-10-13 22:23:37 UTC) #2
jbudorick
lgtm
5 years, 2 months ago (2015-10-13 23:40:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399543004/1
5 years, 2 months ago (2015-10-13 23:45:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 00:37:47 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:38:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c8e7090a85c023084b130f1c1a666fa93aeb151
Cr-Commit-Position: refs/heads/master@{#353925}

Powered by Google App Engine
This is Rietveld 408576698