Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1399533005: Update iOS docs (Closed)

Created:
5 years, 2 months ago by jvanverth1
Modified:
5 years, 2 months ago
Reviewers:
hcm, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update directions #

Total comments: 2

Patch Set 3 : Add testing info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -87 lines) Patch
M site/user/quick/ios.md View 1 2 1 chunk +119 lines, -87 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jvanverth1
I'm not sure about the command line arguments for the tests and benches. It appears ...
5 years, 2 months ago (2015-10-14 20:42:44 UTC) #2
jvanverth1
Fixed up a few things -- I think it's good. PTAL.
5 years, 2 months ago (2015-10-15 15:15:38 UTC) #3
stephana
https://codereview.chromium.org/1399533005/diff/20001/site/user/quick/ios.md File site/user/quick/ios.md (right): https://codereview.chromium.org/1399533005/diff/20001/site/user/quick/ios.md#newcode7 site/user/quick/ios.md:7: 1. Install [XCode](http://developer.apple.com/xcode/). I think it would be helpful ...
5 years, 2 months ago (2015-10-15 15:28:08 UTC) #4
jvanverth1
https://codereview.chromium.org/1399533005/diff/20001/site/user/quick/ios.md File site/user/quick/ios.md (right): https://codereview.chromium.org/1399533005/diff/20001/site/user/quick/ios.md#newcode7 site/user/quick/ios.md:7: 1. Install [XCode](http://developer.apple.com/xcode/). On 2015/10/15 15:28:08, stephana wrote: > ...
5 years, 2 months ago (2015-10-15 16:36:44 UTC) #5
stephana
On 2015/10/15 16:36:44, jvanverth1 wrote: > https://codereview.chromium.org/1399533005/diff/20001/site/user/quick/ios.md > File site/user/quick/ios.md (right): > > https://codereview.chromium.org/1399533005/diff/20001/site/user/quick/ios.md#newcode7 > ...
5 years, 2 months ago (2015-10-15 17:12:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399533005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399533005/40001
5 years, 2 months ago (2015-10-15 17:30:59 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 17:31:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9617431dfe856ff50a4e4954262c8f526e128bb7

Powered by Google App Engine
This is Rietveld 408576698