Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 1399493002: Column balancing refactoring. Don't propagate data during layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more code review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h
index 85823f3ae81fe17263ff83e0f2dbb9c428bb73ed..2f29d06a0dbdcdec6c36a29b2b91cad312a3f42a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h
@@ -113,23 +113,11 @@ public:
void updateMinimumColumnHeight(LayoutUnit offsetInFlowThread, LayoutUnit height);
- // Add a content run, specified by its end position. A content run is appended at every
- // forced/explicit break and at the end of the column set. The content runs are used to
- // determine where implicit/soft breaks will occur, in order to calculate an initial column
- // height.
- void addContentRun(LayoutUnit endOffsetFromFirstPage);
-
// (Re-)calculate the column height if it's auto. This is first and foremost needed by sets that
// are to balance the column height, but even when it isn't to be balanced, this is necessary if
// the multicol container's height is constrained.
bool recalculateColumnHeight(BalancedColumnHeightCalculation);
- // Record space shortage (the amount of space that would have been enough to prevent some
- // element from being moved to the next column) at a column break. The smallest amount of space
- // shortage we find is the amount with which we will stretch the column height, if it turns out
- // after layout that the columns weren't tall enough.
- void recordSpaceShortage(LayoutUnit offsetInFlowThread, LayoutUnit);
-
// Reset previously calculated column height. Will mark for layout if needed.
void resetColumnHeight();

Powered by Google App Engine
This is Rietveld 408576698