third_party/WebKit/Source/core/layout/LayoutFlowThread.h - Issue 1399493002: Column balancing refactoring. Don't propagate data during layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

Issue 1399493002: Column balancing refactoring. Don't propagate data during layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more code review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

index 03b0eb823f11a60d2bad585deb45d14c9bc94160..e9446d8d6f40ff07d71b97a2ba9f6d631814d14a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

@@ -87,11 +87,9 @@ public:

LayoutUnit pageLogicalHeightForOffset(LayoutUnit);

LayoutUnit pageRemainingLogicalHeightForOffset(LayoutUnit, PageBoundaryRule);

- virtual void setPageBreak(LayoutUnit /*offset*/, LayoutUnit /*spaceShortage*/) { }

+ virtual void contentWasLaidOut(LayoutUnit logicalTopInFlowThreadAfterPagination) = 0;

virtual void updateMinimumPageHeight(LayoutUnit /*offset*/, LayoutUnit /*minHeight*/) { }

- virtual bool addForcedColumnBreak(LayoutUnit, LayoutObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = nullptr) { return false; }

virtual bool isPageLogicalHeightKnown() const { return true; }

bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }