Issue 139943006: Remove WebMediaPlayer::supportsFullscreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139943006: Remove WebMediaPlayer::supportsFullscreen() (Closed)

Created:
6 years, 11 months ago by philipj_slow

Modified:
6 years, 11 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, abarth-chromium

CC:
blink-reviews, jamesr, nessy, Rik, dsinclair, philipj_slow, gasubic, jbroman, abarth-chromium, danakj, feature-media-reviews_chromium.org, dglazkov+blink, pdr., krit, adamk+blink_chromium.org, Stephen Chennney, vcarbune.chromium, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove WebMediaPlayer::supportsFullscreen() All the implementations on the Chromium side simply return true, so simplify things as much as possible. Leave only traces of this in HTMLVideoElement to preserve the old behavior, to be removed together with the rest of that prefixed fullscreen API. BUG=334985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165243

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+3 lines, -18 lines)			Patch
Source/core/html/HTMLMediaElement.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
Source/core/html/HTMLVideoElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
Source/core/html/HTMLVideoElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
Source/core/html/MediaController.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
Source/core/html/MediaControllerInterface.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
Source/core/html/shadow/MediaControls.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
Source/platform/graphics/media/MediaPlayer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
Source/web/WebMediaPlayerClientImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
Source/web/WebMediaPlayerClientImpl.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
public/platform/WebMediaPlayer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139943006/1

6 years, 11 months ago (2014-01-16 18:35:48 UTC) #4

Message was sent while issue was closed.

Change committed as 165243

Expand Messages | Collapse Messages