Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 139943002: DM: don't change byte order when unpremultiplying to compare to PNGs. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

DM: don't change byte order when unpremultiplying to compare to PNGs. We've already decoded the PNGs themselves into unpremultiplied bitmaps with native byte order. SkColor is just not the right choice unless you get lucky. dm -w /tmp/dm && dm -r /tmp/dm still works on Linux, and it's much closer to working on Mac: 0 tasks left, 2 failed Failures: matrixconvolution_gpu colormatrix_gpu BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13101

Patch Set 1 #

Patch Set 2 : alpha type not always set to unpremul when unpremul #

Patch Set 3 : reup #

Patch Set 4 : reorder headers #

Patch Set 5 : reorder headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M dm/DMWriteTask.cpp View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 11 months ago (2014-01-15 20:11:43 UTC) #1
reed1
lgtm wonder if we should offer this as a help in the class, as we ...
6 years, 11 months ago (2014-01-15 20:27:00 UTC) #2
mtklein
On 2014/01/15 20:27:00, reed1 wrote: > lgtm > > wonder if we should offer this ...
6 years, 11 months ago (2014-01-15 20:27:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/139943002/100001
6 years, 11 months ago (2014-01-15 20:35:02 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 21:28:27 UTC) #5
Message was sent while issue was closed.
Change committed as 13101

Powered by Google App Engine
This is Rietveld 408576698