[turbofan] Introduce node regions for protection from scheduling.

test/unittests/compiler/js-typed-lowering-unittest.cc

Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index 7d7e267043d8468b298bd7fa2327d473cc87b324..89192032e468953bcfe3a9c50cd92b9fa0bca1e7 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -1066,10 +1066,10 @@ TEST_F(JSTypedLoweringTest, JSCreateFunctionContextViaInlinedAllocation) {
                               context, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
-              IsFinish(IsAllocate(IsNumberConstant(Context::SizeFor(
-                                      8 + Context::MIN_CONTEXT_SLOTS)),
-                                  effect, control),
-                       _));
+              IsFinishRegion(IsAllocate(IsNumberConstant(Context::SizeFor(
+                                            8 + Context::MIN_CONTEXT_SLOTS)),
+                                        effect, control),

[Benedikt Meurer, 2015/10/13 19:12:10]

This test shouldn't pass, because the effect input to the Allocate should a
BeginRegion, not graph->start. There seems to be something wrong here.

[Jarin, 2015/10/14 06:37:20]

Great catch! Fixed. (Unfortunately, we do not run this test because of the test
in the beginning of this test.)

+                             _));
 }
 
 
@@ -1106,10 +1106,10 @@ TEST_F(JSTypedLoweringTest, JSCreateWithContext) {
                               closure, context, frame_state, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
-              IsFinish(IsAllocate(IsNumberConstant(Context::SizeFor(
-                                      Context::MIN_CONTEXT_SLOTS)),
-                                  effect, control),
-                       _));
+              IsFinishRegion(IsAllocate(IsNumberConstant(Context::SizeFor(
+                                            Context::MIN_CONTEXT_SLOTS)),
+                                        effect, control),

[Benedikt Meurer, 2015/10/13 19:12:10]

This test shouldn't pass, because the effect input to the Allocate should a
BeginRegion, not graph->start. There seems to be something wrong here.

[Jarin, 2015/10/14 06:37:20]

Done.

+                             _));
 }
 
 }  // namespace compiler