Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: src/compiler/common-operator.cc

Issue 1399423002: [turbofan] Introduce node regions for protection from scheduling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaks Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/common-operator.cc
diff --git a/src/compiler/common-operator.cc b/src/compiler/common-operator.cc
index ca22bcbcf037d92ebdd1bef38b85c86c300eebcf..6917cafdaa6c7121ae587787cbf1abf01f62ff44 100644
--- a/src/compiler/common-operator.cc
+++ b/src/compiler/common-operator.cc
@@ -678,21 +678,19 @@ const Operator* CommonOperatorBuilder::EffectSet(int arguments) {
}
-const Operator* CommonOperatorBuilder::ValueEffect(int arguments) {
- DCHECK(arguments > 0); // Disallow empty value effects.
- return new (zone()) Operator( // --
- IrOpcode::kValueEffect, Operator::kPure, // opcode
- "ValueEffect", // name
- arguments, 0, 0, 0, 1, 0); // counts
+const Operator* CommonOperatorBuilder::BeginRegion() {
Benedikt Meurer 2015/10/13 19:12:09 Nit: Move to the CACHED_OP_LIST above.
Jarin 2015/10/14 06:37:20 Done.
+ return new (zone()) Operator( // --
+ IrOpcode::kBeginRegion, Operator::kNoThrow, // opcode
+ "BeginRegion", // name
+ 0, 1, 0, 0, 1, 0); // counts
}
-const Operator* CommonOperatorBuilder::Finish(int arguments) {
- DCHECK(arguments > 0); // Disallow empty finishes.
- return new (zone()) Operator( // --
- IrOpcode::kFinish, Operator::kPure, // opcode
- "Finish", // name
- 1, arguments, 0, 1, 0, 0); // counts
+const Operator* CommonOperatorBuilder::FinishRegion() {
Benedikt Meurer 2015/10/13 19:12:09 Nit: Move to the CACHED_OP_LIST above.
Jarin 2015/10/14 06:37:20 Done.
+ return new (zone()) Operator( // --
+ IrOpcode::kFinishRegion, Operator::kNoThrow, // opcode
+ "FinishRegion", // name
+ 1, 1, 0, 1, 1, 0); // counts
}

Powered by Google App Engine
This is Rietveld 408576698