[turbofan] Introduce node regions for protection from scheduling.

test/unittests/compiler/instruction-selector-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/unittests/compiler/instruction-selector-unittest.h"
 
 #include "src/compiler/graph.h"
 #include "src/compiler/schedule.h"
 #include "src/flags.h"
 #include "test/unittests/compiler/compiler-test-utils.h"
@@ skipping 223 matching lines @@
 TARGET_TEST_F(InstructionSelectorTest, ReferenceParameter) {
   StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged);
   Node* param = m.Parameter(0);
   m.Return(param);
   Stream s = m.Build(kAllInstructions);
   EXPECT_TRUE(s.IsReference(param));
 }
 
 
 // -----------------------------------------------------------------------------
-// Finish.
+// FinishRegion.
 
 
-TARGET_TEST_F(InstructionSelectorTest, Finish) {
+TARGET_TEST_F(InstructionSelectorTest, FinishRegion) {
   StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged);
   Node* param = m.Parameter(0);
-  Node* finish = m.AddNode(m.common()->Finish(1), param, m.graph()->start());
+  Node* finish =
+      m.AddNode(m.common()->FinishRegion(), param, m.graph()->start());
   m.Return(finish);
   Stream s = m.Build(kAllInstructions);
   ASSERT_EQ(4U, s.size());
   EXPECT_EQ(kArchNop, s[0]->arch_opcode());
   ASSERT_EQ(1U, s[0]->OutputCount());
   ASSERT_TRUE(s[0]->Output()->IsUnallocated());
   EXPECT_EQ(s.ToVreg(param), s.ToVreg(s[0]->Output()));
   EXPECT_EQ(kArchNop, s[1]->arch_opcode());
   ASSERT_EQ(1U, s[1]->InputCount());
   ASSERT_TRUE(s[1]->InputAt(0)->IsUnallocated());
@@ skipping 65 matching lines @@
 // ValueEffect.
 
 
 TARGET_TEST_F(InstructionSelectorTest, ValueEffect) {
   StreamBuilder m1(this, kMachInt32, kMachPtr);
   Node* p1 = m1.Parameter(0);
   m1.Return(m1.Load(kMachInt32, p1, m1.Int32Constant(0)));
   Stream s1 = m1.Build(kAllInstructions);
   StreamBuilder m2(this, kMachInt32, kMachPtr);
   Node* p2 = m2.Parameter(0);
-  m2.Return(m2.AddNode(m2.machine()->Load(kMachInt32), p2, m2.Int32Constant(0),
-                       m2.AddNode(m2.common()->ValueEffect(1), p2)));
+  m2.Return(
+      m2.AddNode(m2.machine()->Load(kMachInt32), p2, m2.Int32Constant(0),
+                 m2.AddNode(m2.common()->BeginRegion(), m2.graph()->start())));
   Stream s2 = m2.Build(kAllInstructions);
   EXPECT_LE(3U, s1.size());
   ASSERT_EQ(s1.size(), s2.size());
   TRACED_FORRANGE(size_t, i, 0, s1.size() - 1) {
     const Instruction* i1 = s1[i];
     const Instruction* i2 = s2[i];
     EXPECT_EQ(i1->arch_opcode(), i2->arch_opcode());
     EXPECT_EQ(i1->InputCount(), i2->InputCount());
     EXPECT_EQ(i1->OutputCount(), i2->OutputCount());
   }
@@ skipping 262 matching lines @@
   EXPECT_EQ(s.ToVreg(context2), s.ToVreg(call_instr->InputAt(14)));
   // Continuation.
 
   EXPECT_EQ(kArchRet, s[index++]->arch_opcode());
   EXPECT_EQ(index, s.size());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8