[turbofan] Introduce node regions for protection from scheduling.

test/unittests/compiler/change-lowering-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 #include "src/compiler/change-lowering.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/simplified-operator.h"
@@ skipping 110 matching lines @@
 
 
 TARGET_TEST_P(ChangeLoweringCommonTest, ChangeFloat64ToTagged) {
   Node* value = Parameter(Type::Number());
   Reduction r =
       Reduce(graph()->NewNode(simplified()->ChangeFloat64ToTagged(), value));
   ASSERT_TRUE(r.Changed());
   Capture<Node*> heap_number;
   EXPECT_THAT(
       r.replacement(),
-      IsFinish(
+      IsFinishRegion(
           AllOf(CaptureEq(&heap_number),
-                IsAllocateHeapNumber(IsValueEffect(value), graph()->start())),
+                IsAllocateHeapNumber(IsBeginRegion(graph()->start()),
+                                     graph()->start())),
           IsStore(StoreRepresentation(kMachFloat64, kNoWriteBarrier),
                   CaptureEq(&heap_number),
                   IsIntPtrConstant(HeapNumber::kValueOffset - kHeapObjectTag),
                   value, CaptureEq(&heap_number), graph()->start())));
 }
 
 
 TARGET_TEST_P(ChangeLoweringCommonTest, ChangeInt32ToTaggedWithSignedSmall) {
   Node* value = Parameter(Type::SignedSmall());
   Reduction r =
@@ skipping 67 matching lines @@
 
 TARGET_TEST_F(ChangeLowering32Test, ChangeInt32ToTagged) {
   Node* value = Parameter(Type::Integral32());
   Node* node = graph()->NewNode(simplified()->ChangeInt32ToTagged(), value);
   Reduction r = Reduce(node);
   ASSERT_TRUE(r.Changed());
   Capture<Node*> add, branch, heap_number, if_true;
   EXPECT_THAT(
       r.replacement(),
       IsPhi(kMachAnyTagged,
-            IsFinish(AllOf(CaptureEq(&heap_number),
-                           IsAllocateHeapNumber(_, CaptureEq(&if_true))),
-                     IsStore(StoreRepresentation(kMachFloat64, kNoWriteBarrier),
-                             CaptureEq(&heap_number),
-                             IsIntPtrConstant(HeapNumber::kValueOffset -
-                                              kHeapObjectTag),
-                             IsChangeInt32ToFloat64(value),
-                             CaptureEq(&heap_number), CaptureEq(&if_true))),
+            IsFinishRegion(
+                AllOf(CaptureEq(&heap_number),
+                      IsAllocateHeapNumber(_, CaptureEq(&if_true))),
+                IsStore(
+                    StoreRepresentation(kMachFloat64, kNoWriteBarrier),
+                    CaptureEq(&heap_number),
+                    IsIntPtrConstant(HeapNumber::kValueOffset - kHeapObjectTag),
+                    IsChangeInt32ToFloat64(value), CaptureEq(&heap_number),
+                    CaptureEq(&if_true))),
             IsProjection(0, AllOf(CaptureEq(&add),
                                   IsInt32AddWithOverflow(value, value))),
             IsMerge(AllOf(CaptureEq(&if_true), IsIfTrue(CaptureEq(&branch))),
                     IsIfFalse(AllOf(CaptureEq(&branch),
                                     IsBranch(IsProjection(1, CaptureEq(&add)),
                                              graph()->start()))))));
 }
 
 
 TARGET_TEST_F(ChangeLowering32Test, ChangeTaggedToFloat64) {
@@ skipping 73 matching lines @@
   Node* value = Parameter(Type::Number());
   Node* node = graph()->NewNode(simplified()->ChangeUint32ToTagged(), value);
   Reduction r = Reduce(node);
   ASSERT_TRUE(r.Changed());
   Capture<Node*> branch, heap_number, if_false;
   EXPECT_THAT(
       r.replacement(),
       IsPhi(
           kMachAnyTagged,
           IsWord32Shl(value, IsInt32Constant(kSmiTagSize + kSmiShiftSize)),
-          IsFinish(AllOf(CaptureEq(&heap_number),
-                         IsAllocateHeapNumber(_, CaptureEq(&if_false))),
-                   IsStore(StoreRepresentation(kMachFloat64, kNoWriteBarrier),
-                           CaptureEq(&heap_number),
-                           IsInt32Constant(HeapNumber::kValueOffset -
-                                           kHeapObjectTag),
-                           IsChangeUint32ToFloat64(value),
-                           CaptureEq(&heap_number), CaptureEq(&if_false))),
+          IsFinishRegion(
+              AllOf(CaptureEq(&heap_number),
+                    IsAllocateHeapNumber(_, CaptureEq(&if_false))),
+              IsStore(
+                  StoreRepresentation(kMachFloat64, kNoWriteBarrier),
+                  CaptureEq(&heap_number),
+                  IsInt32Constant(HeapNumber::kValueOffset - kHeapObjectTag),
+                  IsChangeUint32ToFloat64(value), CaptureEq(&heap_number),
+                  CaptureEq(&if_false))),
           IsMerge(IsIfTrue(AllOf(
                       CaptureEq(&branch),
                       IsBranch(IsUint32LessThanOrEqual(
                                    value, IsInt32Constant(Smi::kMaxValue)),
                                graph()->start()))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
 
 // -----------------------------------------------------------------------------
@@ skipping 96 matching lines @@
   Node* node = graph()->NewNode(simplified()->ChangeUint32ToTagged(), value);
   Reduction r = Reduce(node);
   ASSERT_TRUE(r.Changed());
   Capture<Node*> branch, heap_number, if_false;
   EXPECT_THAT(
       r.replacement(),
       IsPhi(
           kMachAnyTagged,
           IsWord64Shl(IsChangeUint32ToUint64(value),
                       IsInt64Constant(kSmiTagSize + kSmiShiftSize)),
-          IsFinish(AllOf(CaptureEq(&heap_number),
-                         IsAllocateHeapNumber(_, CaptureEq(&if_false))),
-                   IsStore(StoreRepresentation(kMachFloat64, kNoWriteBarrier),
-                           CaptureEq(&heap_number),
-                           IsInt64Constant(HeapNumber::kValueOffset -
-                                           kHeapObjectTag),
-                           IsChangeUint32ToFloat64(value),
-                           CaptureEq(&heap_number), CaptureEq(&if_false))),
+          IsFinishRegion(
+              AllOf(CaptureEq(&heap_number),
+                    IsAllocateHeapNumber(_, CaptureEq(&if_false))),
+              IsStore(
+                  StoreRepresentation(kMachFloat64, kNoWriteBarrier),
+                  CaptureEq(&heap_number),
+                  IsInt64Constant(HeapNumber::kValueOffset - kHeapObjectTag),
+                  IsChangeUint32ToFloat64(value), CaptureEq(&heap_number),
+                  CaptureEq(&if_false))),
           IsMerge(IsIfTrue(AllOf(
                       CaptureEq(&branch),
                       IsBranch(IsUint32LessThanOrEqual(
                                    value, IsInt32Constant(Smi::kMaxValue)),
                                graph()->start()))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8