Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: src/compiler/verifier.cc

Issue 1399423002: [turbofan] Introduce node regions for protection from scheduling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move RelaxControls Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/change-lowering-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 CHECK_EQ(effect_count, control->op()->ControlInputCount()); 406 CHECK_EQ(effect_count, control->op()->ControlInputCount());
407 CHECK_EQ(input_count, 1 + effect_count); 407 CHECK_EQ(input_count, 1 + effect_count);
408 break; 408 break;
409 } 409 }
410 case IrOpcode::kEffectSet: { 410 case IrOpcode::kEffectSet: {
411 CHECK_EQ(0, value_count); 411 CHECK_EQ(0, value_count);
412 CHECK_EQ(0, control_count); 412 CHECK_EQ(0, control_count);
413 CHECK_LT(1, effect_count); 413 CHECK_LT(1, effect_count);
414 break; 414 break;
415 } 415 }
416 case IrOpcode::kValueEffect: 416 case IrOpcode::kBeginRegion:
417 // TODO(rossberg): what are the constraints on these? 417 // TODO(rossberg): what are the constraints on these?
418 break; 418 break;
419 case IrOpcode::kFinish: { 419 case IrOpcode::kFinishRegion: {
420 // TODO(rossberg): what are the constraints on these? 420 // TODO(rossberg): what are the constraints on these?
421 // Type must be subsumed by input type. 421 // Type must be subsumed by input type.
422 if (typing == TYPED) { 422 if (typing == TYPED) {
423 Node* val = NodeProperties::GetValueInput(node, 0); 423 Node* val = NodeProperties::GetValueInput(node, 0);
424 CHECK(NodeProperties::GetType(val)->Is(NodeProperties::GetType(node))); 424 CHECK(NodeProperties::GetType(val)->Is(NodeProperties::GetType(node)));
425 } 425 }
426 break; 426 break;
427 } 427 }
428 case IrOpcode::kFrameState: 428 case IrOpcode::kFrameState:
429 // TODO(jarin): what are the constraints on these? 429 // TODO(jarin): what are the constraints on these?
(...skipping 778 matching lines...) Expand 10 before | Expand all | Expand 10 after
1208 replacement->op()->EffectOutputCount() > 0); 1208 replacement->op()->EffectOutputCount() > 0);
1209 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1209 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1210 replacement->opcode() == IrOpcode::kFrameState); 1210 replacement->opcode() == IrOpcode::kFrameState);
1211 } 1211 }
1212 1212
1213 #endif // DEBUG 1213 #endif // DEBUG
1214 1214
1215 } // namespace compiler 1215 } // namespace compiler
1216 } // namespace internal 1216 } // namespace internal
1217 } // namespace v8 1217 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/change-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698