Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1399403002: Reland of "[heap] Divide available memory upon compaction tasks" (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Divide available memory upon compaction tasks" This reverts commit ec1046f9f8cd52488917b439c598296620103d39. Original message: [heap] Divide available memory upon compaction tasks - Fairly (round-robin) divide available memory upon compaction tasks. - Ensure an upper limit (of memory) since dividing is O(n) for n free-space nodes. - Refill from free lists managed by sweeper once a compaction space becomes empty. Assumption for dividing memory: Memory in the free lists is sparse upon starting compaction (which means that only few nodes are available), except for memory reducer GCs, which happen in idle time though (so it's less of a problem). BUG=chromium:524425 LOG=N Committed: https://crrev.com/a805be73f6f97645450124f75c0f7417ec7b3e70 Cr-Commit-Position: refs/heads/master@{#31329}

Patch Set 1 : Baseline #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -66 lines) Patch
M src/heap/mark-compact.h View 2 chunks +14 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 4 chunks +7 lines, -30 lines 0 comments Download
M src/heap/spaces.h View 1 6 chunks +31 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 6 chunks +127 lines, -8 lines 0 comments Download
M test/cctest/heap-tester.h View 2 chunks +32 lines, -11 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 5 chunks +156 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399403002/20001
5 years, 2 months ago (2015-10-16 08:30:25 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 09:04:40 UTC) #4
Michael Lippautz
PTAL - bug was present in ToT (since merging experimental GC ;)) and fixed separately.
5 years, 2 months ago (2015-10-16 09:18:57 UTC) #6
Hannes Payer (out of office)
LGTM (rubber-stamped)
5 years, 2 months ago (2015-10-16 10:23:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399403002/20001
5 years, 2 months ago (2015-10-16 10:32:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 10:34:08 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a805be73f6f97645450124f75c0f7417ec7b3e70 Cr-Commit-Position: refs/heads/master@{#31329}
5 years, 2 months ago (2015-10-16 10:34:34 UTC) #11
Michael Lippautz
5 years, 2 months ago (2015-10-16 11:54:13 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1412643002/ by mlippautz@chromium.org.

The reason for reverting is: Failing:
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Str....

Powered by Google App Engine
This is Rietveld 408576698