Issue 13994020: Buffer returned textures from render to VDA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13994020: Buffer returned textures from render to VDA (Closed)

Created:
7 years, 8 months ago by hshi1

Modified:
7 years, 8 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Buffer returned textures from render to VDA This is CrOS ARM only hot fix for tearing/out of order frames caused by render/decode synchronization issues until we understand the underlying problem (presumably in the driver) better. The main effect of this change is to add an extra delay of 2 frames between draw and decode to clearly separate both. We had a similar hack in Flash when synchronization was broken (then in particular > 2 was used to achieve sufficient delay). We have a total of 8 PictureBuffers in flight but only need about 4 for smooth playback. (With this change we are down to 6 which is still sufficient.) BUG=chromium:225563 AUTHOR=ihf@chromium.org TEST=Ran on Daisy with different problematic videos and did not notice problems. TBR=sheu TBR=xhwang NOTRY=true Original Review CL: https://codereview.chromium.org/14238003/ Landing this on behalf of ihf@ - CQ is down. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194267

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/common/gpu/media/exynos_video_decode_accelerator.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

hshi1

7 years, 8 months ago (2013-04-16 00:53:49 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r194267 (presubmit successful).

Expand Messages | Collapse Messages