Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1399383002: Reenable AppleEventUtilTest.ValueToAppleEventDescriptor by removing the failing case. (Closed)

Created:
5 years, 2 months ago by Avi (use Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Andre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable AppleEventUtilTest.ValueToAppleEventDescriptor by removing the failing case. BUG=239807 TEST=AppleEventUtilTest.ValueToAppleEventDescriptor Committed: https://crrev.com/265ed5079f1b1d47b62d9698dd83ec2208a62a12 Cr-Commit-Position: refs/heads/master@{#353845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399383002/1
5 years, 2 months ago (2015-10-13 01:06:54 UTC) #2
Avi (use Gerrit)
So this was disabled years ago because one of the string tests kept flaking in ...
5 years, 2 months ago (2015-10-13 01:27:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-13 01:29:55 UTC) #6
Andre
lgtm
5 years, 2 months ago (2015-10-13 17:14:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399383002/1
5 years, 2 months ago (2015-10-13 20:30:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 20:45:42 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/265ed5079f1b1d47b62d9698dd83ec2208a62a12 Cr-Commit-Position: refs/heads/master@{#353845}
5 years, 2 months ago (2015-10-13 20:47:24 UTC) #11
benwells
5 years, 2 months ago (2015-10-13 22:51:52 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1395363005/ by benwells@chromium.org.

The reason for reverting is: This caused failures on mac asan. See
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%...

Will put more info on the linked bug.

The asan failure is hopefully a good clue to fix the underlying flakiness :).

Powered by Google App Engine
This is Rietveld 408576698