Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 1399363004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index a042183870385fae365aa66e76d1a92d2de05e67..e74b04d961a53f2e6187f083e23c1963d5fe2d30 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -4,6 +4,7 @@
#include "content/browser/service_worker/service_worker_dispatcher_host.h"
+#include "base/command_line.h"
#include "base/logging.h"
#include "base/profiler/scoped_tracker.h"
#include "base/strings/utf_string_conversions.h"
@@ -15,6 +16,7 @@
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_context_wrapper.h"
#include "content/browser/service_worker/service_worker_handle.h"
+#include "content/browser/service_worker/service_worker_navigation_handle_core.h"
#include "content/browser/service_worker/service_worker_registration.h"
#include "content/browser/service_worker/service_worker_registration_handle.h"
#include "content/common/service_worker/embedded_worker_messages.h"
@@ -23,6 +25,7 @@
#include "content/common/service_worker/service_worker_utils.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/common/content_client.h"
+#include "content/public/common/content_switches.h"
#include "content/public/common/origin_util.h"
#include "ipc/ipc_message_macros.h"
#include "net/base/net_util.h"
@@ -733,10 +736,35 @@ void ServiceWorkerDispatcherHost::OnProviderCreated(
bad_message::SWDH_PROVIDER_CREATED_NO_HOST);
return;
}
- scoped_ptr<ServiceWorkerProviderHost> provider_host(
- new ServiceWorkerProviderHost(render_process_id_, route_id, provider_id,
- provider_type, GetContext()->AsWeakPtr(),
- this));
+
+ scoped_ptr<ServiceWorkerProviderHost> provider_host;
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableBrowserSideNavigation) &&
+ ServiceWorkerUtils::IsBrowserAssignedProviderId(provider_id)) {
+ // PlzNavigate
+ // Retrieve the provider host previously created for navigation requests.
+ auto result = GetContext()->GetNavigationHandleCores().find(provider_id);
+ if (result != GetContext()->GetNavigationHandleCores().end())
+ provider_host = result->second->RetrievePreCreatedHost();
+ if (provider_host == nullptr) {
+ bad_message::ReceivedBadMessage(
+ this, bad_message::SWDH_PROVIDER_CREATED_NO_HOST);
+ return;
+ }
+ DCHECK_EQ(SERVICE_WORKER_PROVIDER_FOR_WINDOW, provider_type);
+ provider_host->CompleteNavigationInitialized(render_process_id_, route_id,
+ this);
+ } else {
+ if (ServiceWorkerUtils::IsBrowserAssignedProviderId(provider_id)) {
+ bad_message::ReceivedBadMessage(
+ this, bad_message::SWDH_PROVIDER_CREATED_NO_HOST);
+ return;
+ }
+ provider_host =
+ scoped_ptr<ServiceWorkerProviderHost>(new ServiceWorkerProviderHost(
+ render_process_id_, route_id, provider_id, provider_type,
+ GetContext()->AsWeakPtr(), this));
+ }
kinuko 2015/10/20 14:46:07 Since this logic has bloated quite a bit I feel it
michaeln 2015/10/20 22:12:53 we're in a sw specific class, do you mean to move
kinuko 2015/10/23 02:37:45 Sorry, I was going to put this comment for the cha
GetContext()->AddProviderHost(provider_host.Pass());
}

Powered by Google App Engine
This is Rietveld 408576698