Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1399363004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Kinuko's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 255684a5683e0c29ca08255f2da079451abeecf2..fb0af1038828b81c7b51cd7a69729963af175224 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2645,20 +2645,18 @@ void RenderFrameImpl::didCreateDataSource(blink::WebLocalFrame* frame,
// Create the serviceworker's per-document network observing object if it
// does not exist (When navigation happens within a page, the provider already
// exists).
- if (!ServiceWorkerNetworkProvider::FromDocumentState(
- DocumentState::FromDataSource(datasource))) {
- ServiceWorkerProviderType provider_type =
- SERVICE_WORKER_PROVIDER_FOR_WINDOW;
- if ((frame->effectiveSandboxFlags() & blink::WebSandboxFlags::Origin) ==
- blink::WebSandboxFlags::Origin) {
- provider_type = SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME;
- }
- scoped_ptr<ServiceWorkerNetworkProvider> network_provider(
- new ServiceWorkerNetworkProvider(routing_id_, provider_type));
- ServiceWorkerNetworkProvider::AttachToDocumentState(
- DocumentState::FromDataSource(datasource),
- network_provider.Pass());
- }
+ if (ServiceWorkerNetworkProvider::FromDocumentState(
+ DocumentState::FromDataSource(datasource)))
+ return;
+
+ NavigationStateImpl* navigation_state = static_cast<NavigationStateImpl*>(
+ DocumentState::FromDataSource(datasource)->navigation_state());
+
+ ServiceWorkerNetworkProvider::AttachToDocumentState(
+ DocumentState::FromDataSource(datasource),
+ ServiceWorkerNetworkProvider::CreateForNavigation(
+ routing_id_, navigation_state->request_params(),
+ frame->effectiveSandboxFlags(), content_initiated));
}
void RenderFrameImpl::didStartProvisionalLoad(blink::WebLocalFrame* frame,
@@ -3417,12 +3415,14 @@ void RenderFrameImpl::willSendRequest(
ServiceWorkerNetworkProvider* provider =
ServiceWorkerNetworkProvider::FromDocumentState(
DocumentState::FromDataSource(frame->provisionalDataSource()));
+ DCHECK(provider);
provider_id = provider->provider_id();
}
} else if (frame->dataSource()) {
ServiceWorkerNetworkProvider* provider =
ServiceWorkerNetworkProvider::FromDocumentState(
DocumentState::FromDataSource(frame->dataSource()));
+ DCHECK(provider);
provider_id = provider->provider_id();
// Explicitly set the SkipServiceWorker flag here if the renderer process
// hasn't received SetControllerServiceWorker message.

Powered by Google App Engine
This is Rietveld 408576698