content/browser/frame_host/navigation_request.h - Issue 1399363004: PlzNavigate: Make ServiceWorker work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 1399363004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Kinuko's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | content/browser/service_worker/service_worker_provider_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.h

diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h

index 57218e7c55c73469cd522572a5cce979775c1d36..294d086ce677a3f8817dd8ec3b4643e594a10944 100644

--- a/content/browser/frame_host/navigation_request.h

+++ b/content/browser/frame_host/navigation_request.h

@@ -171,9 +171,11 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {

// redirects.

// Note: |common_params_| and |begin_params_| are not const as they can be

// modified during redirects.

+ // Note: |request_params_| is not const because service_worker_provider_id

+ // and should_create_service_worker will be set in OnResponseStarted.

CommonNavigationParams common_params_;

BeginNavigationParams begin_params_;

- const RequestNavigationParams request_params_;

+ RequestNavigationParams request_params_;

const bool browser_initiated_;

NavigationState state_;