Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1399363002: Add ffmpeg (chromium's branch) to third_party for use in mojo media. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/BUILDCONFIG.gn ('K') | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index d595dc8e6f4afdd1c1f78edb21a9c50c04e9c158..dfa9801a6a35c68dd0fa0f100fa1ff50ed111f8d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1069,6 +1069,26 @@ config("no_size_t_to_int_warning") {
}
}
+# Some code presumes that pointers to structures/objects are compatible
+# regardless of whether what they point to is already known to be valid.
+# gcc 4.9 and earlier had no way of suppressing this warning without
+# supressing the rest of them. Here we centralize the identification of
+# the gcc 4.9 toolchains.
jamesr 2015/10/13 00:13:56 I'm pretty sure we will never use a gcc 4.9 toolch
+config("no_incompatible_pointer_warnings") {
+ cflags = []
+ if (is_clang) {
+ cflags += [ "-Wno-incompatible-pointer-types" ]
+ } else if (current_cpu == "mipsel") {
jamesr 2015/10/13 00:13:56 we aren't building anything targeting mips
+ cflags += [ "-w" ]
+ } else if (is_chromeos && current_cpu == "arm") {
jamesr 2015/10/13 00:13:56 we aren't building for chromeos
+ cflags += [ "-w" ]
+ }
jamesr 2015/10/13 00:13:56 was there supposed to be something gcc 4.9 related
+}
+
+# //third_party/ffmpeg/BUILD.gn wants to remove this, so we need a placeholder.
+config("default_optimization") {
+}
+
# Optimization -----------------------------------------------------------------
#
# Note that BUILDCONFIG.gn sets up a variable "default_optimization_config"
« build/config/BUILDCONFIG.gn ('K') | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698