Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1399363002: Add ffmpeg (chromium's branch) to third_party for use in mojo media. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Removed unnecessary cases from no_incompatible_pointer_warnings Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 # Note that this can be applied regardless of platform and architecture to 1062 # Note that this can be applied regardless of platform and architecture to
1063 # clean up the call sites. This will only apply the flag when necessary. 1063 # clean up the call sites. This will only apply the flag when necessary.
1064 # 1064 #
1065 # TODO(jschuh): crbug.com/167187 fix this and delete this config. 1065 # TODO(jschuh): crbug.com/167187 fix this and delete this config.
1066 config("no_size_t_to_int_warning") { 1066 config("no_size_t_to_int_warning") {
1067 if (is_win && current_cpu == "x64") { 1067 if (is_win && current_cpu == "x64") {
1068 cflags = [ "/wd4267" ] 1068 cflags = [ "/wd4267" ]
1069 } 1069 }
1070 } 1070 }
1071 1071
1072 # Some code presumes that pointers to structures/objects are compatible
1073 # regardless of whether what they point to is already known to be valid.
1074 # gcc 4.9 and earlier had no way of suppressing this warning without
1075 # supressing the rest of them. Here we centralize the identification of
1076 # the gcc 4.9 toolchains.
jamesr 2015/10/13 22:33:56 the comment still doesn't make sense, at least to
1077 config("no_incompatible_pointer_warnings") {
1078 cflags = []
1079 if (is_clang) {
1080 cflags += [ "-Wno-incompatible-pointer-types" ]
1081 }
1082 }
1083
1084 # //third_party/ffmpeg/BUILD.gn wants to remove this, so we need a placeholder.
1085 config("default_optimization") {
1086 }
1087
1072 # Optimization ----------------------------------------------------------------- 1088 # Optimization -----------------------------------------------------------------
1073 # 1089 #
1074 # Note that BUILDCONFIG.gn sets up a variable "default_optimization_config" 1090 # Note that BUILDCONFIG.gn sets up a variable "default_optimization_config"
1075 # which it will assign to the config it implicitly applies to every target. If 1091 # which it will assign to the config it implicitly applies to every target. If
1076 # you want to override the optimization level for your target, remove this 1092 # you want to override the optimization level for your target, remove this
1077 # config (which will expand differently for debug or release builds), and then 1093 # config (which will expand differently for debug or release builds), and then
1078 # add back the one you want to override it with: 1094 # add back the one you want to override it with:
1079 # 1095 #
1080 # configs -= default_optimization_config 1096 # configs -= default_optimization_config
1081 # configs += [ "//build/config/compiler/optimize_max" ] 1097 # configs += [ "//build/config/compiler/optimize_max" ]
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1246 cflags += [ "-gsplit-dwarf" ] 1262 cflags += [ "-gsplit-dwarf" ]
1247 } 1263 }
1248 } 1264 }
1249 } 1265 }
1250 1266
1251 config("no_symbols") { 1267 config("no_symbols") {
1252 if (!is_win) { 1268 if (!is_win) {
1253 cflags = [ "-g0" ] 1269 cflags = [ "-g0" ]
1254 } 1270 }
1255 } 1271 }
OLDNEW
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698