Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13993027: ash: Update app list button. (Closed)

Created:
7 years, 7 months ago by xiyuan
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Update app list button. - Update the icons assets; - Make app list button a ToggleImageButton and wire its toggle state with app list UI visibility; - Make app list button icon vertically center aligned and get rid of the special handling; - Expose toggled state from ToggleImageButton so that it could be checked in test; BUG=235994 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197366

Patch Set 1 #

Total comments: 6

Patch Set 2 : for #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -57 lines) Patch
M ash/launcher/app_list_button.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M ash/launcher/app_list_button.cc View 5 chunks +27 lines, -2 lines 0 comments Download
M ash/launcher/launcher_unittest.cc View 1 4 chunks +52 lines, -2 lines 0 comments Download
M ash/launcher/launcher_view.cc View 2 chunks +1 line, -28 lines 0 comments Download
M ash/resources/default_100_percent/common/launcher/launcher_appmenu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/launcher/launcher_appmenu_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/launcher/launcher_appmenu_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/launcher/launcher_appmenu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/launcher/launcher_appmenu_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/launcher/launcher_appmenu_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/shell.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +12 lines, -14 lines 0 comments Download
M ash/wm/app_list_controller.h View 7 chunks +21 lines, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 8 chunks +46 lines, -15 lines 0 comments Download
A ash/wm/app_list_controller_observer.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
M ui/views/controls/button/image_button.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xiyuan
7 years, 7 months ago (2013-04-29 18:02:16 UTC) #1
sky
https://codereview.chromium.org/13993027/diff/1/ash/launcher/app_list_button.h File ash/launcher/app_list_button.h (right): https://codereview.chromium.org/13993027/diff/1/ash/launcher/app_list_button.h#newcode41 ash/launcher/app_list_button.h:41: bool visible, const aura::RootWindow* root_window) OVERRIDE; nit: when you ...
7 years, 7 months ago (2013-04-29 20:40:54 UTC) #2
xiyuan
https://codereview.chromium.org/13993027/diff/1/ash/launcher/app_list_button.h File ash/launcher/app_list_button.h (right): https://codereview.chromium.org/13993027/diff/1/ash/launcher/app_list_button.h#newcode41 ash/launcher/app_list_button.h:41: bool visible, const aura::RootWindow* root_window) OVERRIDE; On 2013/04/29 20:40:55, ...
7 years, 7 months ago (2013-04-29 21:12:45 UTC) #3
sky
LGTM
7 years, 7 months ago (2013-04-29 21:39:00 UTC) #4
xiyuan
7 years, 7 months ago (2013-04-30 14:54:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r197366 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698