Issue 13993025: Remove the whole ios specific WebKit checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13993025: Remove the whole ios specific WebKit checkout. (Closed)

Created:
7 years, 7 months ago by M-A Ruel

Modified:
5 years, 11 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, szager1, Mike Stip (use stip instead), karen, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the whole ios specific WebKit checkout. FWIU, ios port can build with XCode's WebKit checkout. R=stuartmorgan@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : reset try job status #

Patch Set 3 : reset try job status now that apply_issue.py was changed #

Patch Set 4 : reset try job result #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	DEPS	View		2 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Also note https://code.google.com/p/chromium/issues/detail?id=236505 which is getting in the way of testing this.

7 years, 7 months ago (2013-04-29 19:02:49 UTC) #1

stuartmorgan

7 years, 7 months ago (2013-04-29 21:05:11 UTC) #2

I don't understand this change at all. What's the motivation for this? What's
the plan for getting the necessary headers?

We went through the trouble of setting up the header pull for a reason, so I'm
confused why there's a CL to remove it without any prior discussion. The plan
I've discussed with infra is to transition to Blink versions of the mirrors, not
scrap the whole thing.

> Remove the whole ios specific WebKit checkout.

I don't see how a clean checkout with this patch applied could possibly build.
Remember all the CQ jobs failing because gclient was nuking the WebKit
directory? Not checking it out in the first place is equivalent to deleting it.

> FWIU, ios port can build with XCode's WebKit checkout.

I don't know what this means. Xcode is an IDE, it doesn't have a checkout of
anything.

Expand Messages | Collapse Messages