Issue 13993021: SECTION_EMAIL -> section. Whoops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13993021: SECTION_EMAIL -> section. Whoops. (Closed)

Created:
7 years, 8 months ago by Dan Beam

Modified:
7 years, 8 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SECTION_EMAIL -> section. Whoops. R=isherman@chromium.org BUG=none TEST=I've been told not to test private methods. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196018

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM. Regarding testing: You shouldn't directly test private methods, but you should test the public ...

7 years, 8 months ago (2013-04-24 00:08:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/13993021/1

7 years, 8 months ago (2013-04-24 00:18:00 UTC) #3

Message was sent while issue was closed.

Change committed as 196018

Expand Messages | Collapse Messages