Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 13993006: Skip test-cpu-profiler/CollectCpuProfile on Arm simulator (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Stack traversal doesn't work properly on Arm simulator so disabling the test there. BUG=2621 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14213

Patch Set 1 #

Patch Set 2 : Also reenable the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 8 months ago (2013-04-10 14:13:37 UTC) #1
loislo
lgtm
7 years, 8 months ago (2013-04-10 14:15:33 UTC) #2
Sven Panne
lgtm
7 years, 8 months ago (2013-04-10 14:28:04 UTC) #3
yurys
7 years, 8 months ago (2013-04-10 14:31:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698