Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

Issue 1399273003: fpdfsdk/ differences with XFA (for didactic purposes only). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Regenerate after taking juns patch Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/include/fpdfapi/fpdf_parser.h" 5 #include "core/include/fpdfapi/fpdf_parser.h"
6 #include "fpdfsdk/include/jsapi/fxjs_v8.h" 6 #include "fpdfsdk/include/jsapi/fxjs_v8.h"
7 #include "testing/embedder_test.h" 7 #include "testing/embedder_test.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "third_party/base/nonstd_unique_ptr.h" 9 #include "third_party/base/nonstd_unique_ptr.h"
10 10
(...skipping 12 matching lines...) Expand all
23 m_pIsolate = v8::Isolate::New(params); 23 m_pIsolate = v8::Isolate::New(params);
24 } 24 }
25 25
26 ~FXJSV8Embeddertest() override { m_pIsolate->Dispose(); } 26 ~FXJSV8Embeddertest() override { m_pIsolate->Dispose(); }
27 27
28 void SetUp() override { 28 void SetUp() override {
29 EmbedderTest::SetExternalIsolate(m_pIsolate); 29 EmbedderTest::SetExternalIsolate(m_pIsolate);
30 EmbedderTest::SetUp(); 30 EmbedderTest::SetUp();
31 31
32 v8::Isolate::Scope isolate_scope(m_pIsolate); 32 v8::Isolate::Scope isolate_scope(m_pIsolate);
33 #ifdef PDF_ENABLE_XFA
34 v8::Locker locker(m_pIsolate);
35 #endif
33 v8::HandleScope handle_scope(m_pIsolate); 36 v8::HandleScope handle_scope(m_pIsolate);
34 FXJS_PerIsolateData::SetUp(m_pIsolate); 37 FXJS_PerIsolateData::SetUp(m_pIsolate);
35 FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext, 38 FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext,
36 &m_StaticObjects); 39 &m_StaticObjects);
37 } 40 }
38 41
39 void TearDown() override { 42 void TearDown() override {
40 FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects); 43 FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects);
41 m_pPersistentContext.Reset(); 44 m_pPersistentContext.Reset();
42 FXJS_Release(); 45 FXJS_Release();
43 EmbedderTest::TearDown(); 46 EmbedderTest::TearDown();
44 } 47 }
45 48
46 v8::Isolate* isolate() { return m_pIsolate; } 49 v8::Isolate* isolate() { return m_pIsolate; }
47 v8::Local<v8::Context> GetV8Context() { 50 v8::Local<v8::Context> GetV8Context() {
48 return m_pPersistentContext.Get(m_pIsolate); 51 return m_pPersistentContext.Get(m_pIsolate);
49 } 52 }
50 53
51 private: 54 private:
52 nonstd::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator; 55 nonstd::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;
53 v8::Isolate* m_pIsolate; 56 v8::Isolate* m_pIsolate;
54 v8::Global<v8::Context> m_pPersistentContext; 57 v8::Global<v8::Context> m_pPersistentContext;
55 std::vector<v8::Global<v8::Object>*> m_StaticObjects; 58 std::vector<v8::Global<v8::Object>*> m_StaticObjects;
56 }; 59 };
57 60
58 TEST_F(FXJSV8Embeddertest, Getters) { 61 TEST_F(FXJSV8Embeddertest, Getters) {
59 v8::Isolate::Scope isolate_scope(isolate()); 62 v8::Isolate::Scope isolate_scope(isolate());
63 #ifdef PDF_ENABLE_XFA
64 v8::Locker locker(isolate());
65 #endif
60 v8::HandleScope handle_scope(isolate()); 66 v8::HandleScope handle_scope(isolate());
61 v8::Context::Scope context_scope(GetV8Context()); 67 v8::Context::Scope context_scope(GetV8Context());
62 68
63 FXJSErr error; 69 FXJSErr error;
64 int sts = FXJS_Execute(isolate(), nullptr, kScript, &error); 70 int sts = FXJS_Execute(isolate(), nullptr, kScript, &error);
65 EXPECT_EQ(0, sts); 71 EXPECT_EQ(0, sts);
66 72
67 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate()); 73 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());
68 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred"); 74 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");
69 EXPECT_TRUE(fred->IsNumber()); 75 EXPECT_TRUE(fred->IsNumber());
70 } 76 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698