Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 1399253005: Fix layout of omnibox rows for material design (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/layout_constants.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_result_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
index 066d43402f761642699170cecbcd28ead10bd624..c97ddb9beae5b0be99137747c4f51d72a7dcaffd 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
@@ -117,7 +117,7 @@ gfx::Rect OmniboxPopupContentsView::GetPopupBounds() const {
void OmniboxPopupContentsView::LayoutChildren() {
gfx::Rect contents_rect = GetContentsBounds();
- contents_rect.Inset(GetLayoutInsets(OMNIBOX_DROPDOWN_TEXT));
+ contents_rect.Inset(GetLayoutInsets(OMNIBOX_DROPDOWN));
contents_rect.Inset(0, views::NonClientFrameView::kClientEdgeThickness, 0, 0);
// In the non-material dropdown, the colored/clickable regions within the
@@ -422,7 +422,7 @@ int OmniboxPopupContentsView::CalculatePopupHeight() {
// amount of space between the text and the popup border as there is in the
// interior between each row of text.
return popup_height + views::NonClientFrameView::kClientEdgeThickness +
- GetLayoutInsets(OMNIBOX_DROPDOWN_TEXT).height() +
+ GetLayoutInsets(OMNIBOX_DROPDOWN).height() +
bottom_shadow_->height() -
GetLayoutConstant(OMNIBOX_DROPDOWN_BORDER_INTERIOR);
}
« no previous file with comments | « chrome/browser/ui/views/layout_constants.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_result_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698