Fix layout of omnibox rows for material design

chrome/browser/ui/views/layout_constants.cc

Index: chrome/browser/ui/views/layout_constants.cc
diff --git a/chrome/browser/ui/views/layout_constants.cc b/chrome/browser/ui/views/layout_constants.cc
index 7e8a081f2b933856f22f818f5ba77a89e147e3a9..68dd76b6f8b1b022b22da266602da1853f56296d 100644
--- a/chrome/browser/ui/views/layout_constants.cc
+++ b/chrome/browser/ui/views/layout_constants.cc
@@ -95,7 +95,8 @@ gfx::Insets GetLayoutInsets(LayoutInset inset) {
   const int kAvatarRightPadding[] = {-6, 4, 4};
   const int kAvatarBottomPadding[] = {2, 4, 4};
   const int kOmniboxDropdownIconPadding[] = {2, 4, 8};
-  const int kOmniboxDropdownTextPadding[] = {3, 4, 8};
+  const int kOmniboxDropdownPadding[] = {3, 4, 4};
+  const int kOmniboxDropdownTextPadding[] = {3, 3, 3};

[Peter Kasting, 2015/10/19 20:47:11]

Should this one become not-a-layout-constant?

[tdanderson, 2015/10/20 14:20:15]

I'd rather keep it here for now; it's nice to have
all related constants in one place, and there is
still a chance that these could need adjusting.

   const int kTabBottomPadding[] = {2, 2, 2};
   const int kTabLeftPadding[] = {20, 20, 20};
   const int kTabRightPadding[] = {20, 20, 20};
@@ -112,6 +113,10 @@ gfx::Insets GetLayoutInsets(LayoutInset inset) {
       return gfx::Insets(0, kAvatarLeftPadding[mode],
                          kAvatarBottomPadding[mode], kAvatarRightPadding[mode]);
     }
+    case OMNIBOX_DROPDOWN: {
+      const int padding = kOmniboxDropdownPadding[mode];
+      return gfx::Insets(padding, 0, padding, 0);
+    }
     case OMNIBOX_DROPDOWN_ICON: {
       const int padding = kOmniboxDropdownIconPadding[mode];
       return gfx::Insets(padding, 0, padding, 0);