Make base::IsUnicodeWhitespace('\0') return false.

Make base::IsUnicodeWhitespace('\0') return false.

BUG=542759
Committed: https://crrev.com/e61e2b17851818c993d4fb509b4076616ea8292b
Cr-Commit-Position: refs/heads/master@{#353905}

[eroman, 2015-10-13 18:17:59]

eroman@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-10-13 21:41:51]

lgtm

https://codereview.chromium.org/1399253004/diff/20001/base/strings/string_uti...
File base/strings/string_util_unittest.cc (right):

https://codereview.chromium.org/1399253004/diff/20001/base/strings/string_uti...
base/strings/string_util_unittest.cc:1097:
EXPECT_TRUE(IsUnicodeWhitespace(L'\n'));
Can you add a non-ASCII one as well, like:

0xA0 (no break space, interesting because it's the only non-ASCII 8-bit one).
0x3000 (idographic space)

[eroman, 2015-10-13 22:04:22]

https://codereview.chromium.org/1399253004/diff/20001/base/strings/string_uti...
File base/strings/string_util_unittest.cc (right):

https://codereview.chromium.org/1399253004/diff/20001/base/strings/string_uti...
base/strings/string_util_unittest.cc:1097:
EXPECT_TRUE(IsUnicodeWhitespace(L'\n'));
On 2015/10/13 21:41:51, brettw wrote:
> Can you add a non-ASCII one as well, like:
> 
> 0xA0 (no break space, interesting because it's the only non-ASCII 8-bit one).
> 0x3000 (idographic space)

Done. (Also added a non-ASCII non-whitespace test)

[eroman, 2015-10-13 22:05:39]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-10-13 22:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1399253004/#ps40001
(title: "Add non-ASCII codepoint tests")

[commit-bot: I haz the power, 2015-10-13 22:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399253004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399253004/40001

[commit-bot: I haz the power, 2015-10-13 23:39:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-13 23:42:11]

Patchset 3 (id:??) landed as
https://crrev.com/e61e2b17851818c993d4fb509b4076616ea8292b
Cr-Commit-Position: refs/heads/master@{#353905}