Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1399243004: Add script that generates X509 certificates for testing dart:io SecureSocket (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add script that generates X509 certificates for testing dart:io SecureSocket BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/184c7b0182b537f174ef539c11ebd04de9ce9e0d

Patch Set 1 #

Patch Set 2 : Fix long line #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -184 lines) Patch
M tests/standalone/io/certificates/README View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/certificates/server_chain.pem View 1 chunk +51 lines, -51 lines 0 comments Download
M tests/standalone/io/certificates/server_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M tests/standalone/io/certificates/trusted_certs.pem View 1 chunk +16 lines, -17 lines 0 comments Download
M tests/standalone/io/certificates/untrusted_server_chain.pem View 1 chunk +51 lines, -51 lines 0 comments Download
M tests/standalone/io/certificates/untrusted_server_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
A tests/standalone/io/create_sample_certificates.sh View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A + tests/standalone/io/intermediate_authority_v3_extensions View 1 chunk +5 lines, -11 lines 0 comments Download
A tests/standalone/io/localhost_v3_extensions View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
5 years, 2 months ago (2015-10-13 15:08:19 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1399243004/diff/20001/tests/standalone/io/create_sample_certificates File tests/standalone/io/create_sample_certificates (right): https://codereview.chromium.org/1399243004/diff/20001/tests/standalone/io/create_sample_certificates#newcode4 tests/standalone/io/create_sample_certificates:4: # BSD-style license that can be found in ...
5 years, 2 months ago (2015-10-14 07:22:12 UTC) #3
Bill Hesse
https://codereview.chromium.org/1399243004/diff/20001/tests/standalone/io/create_sample_certificates File tests/standalone/io/create_sample_certificates (right): https://codereview.chromium.org/1399243004/diff/20001/tests/standalone/io/create_sample_certificates#newcode4 tests/standalone/io/create_sample_certificates:4: # BSD-style license that can be found in the ...
5 years, 2 months ago (2015-10-14 08:50:11 UTC) #4
Bill Hesse
5 years, 2 months ago (2015-10-14 08:50:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
184c7b0182b537f174ef539c11ebd04de9ce9e0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698