public/platform/WebLayer.h - Issue 139923006: [Cleanup] Follow Up of Pinch/Zoom Infrastucture & Plumbing CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebLayer.h

Issue 139923006: [Cleanup] Follow Up of Pinch/Zoom Infrastucture & Plumbing CL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebLayer.h

diff --git a/public/platform/WebLayer.h b/public/platform/WebLayer.h

index 2ffb901f23ca5afd6cc164b69ad6fc3d0e69bfdf..fc8e210ad434bf105e33f1565943e793d096661b 100644

--- a/public/platform/WebLayer.h

+++ b/public/platform/WebLayer.h

@@ -173,8 +173,7 @@ public:

virtual WebSize maxScrollPosition() const = 0;

// To set a WebLayer as scrollable we must specify the corresponding clip layer.

- // TODO(wjmaclean) Make this pure virtual once https://codereview.chromium.org/23983047 lands.

- virtual void setScrollClipLayer(WebLayer*) { }

+ virtual void setScrollClipLayer(WebLayer*) = 0;

wjmaclean 2014/01/31 13:38:25 nit: Don't need a blank line after this one.

deepak.sa 2014/02/01 09:15:24 Done.

virtual bool scrollable() const = 0;

virtual void setUserScrollable(bool horizontal, bool vertical) = 0;

@@ -216,10 +215,6 @@ public:

virtual bool isOrphan() const = 0;

virtual void setWebLayerClient(WebLayerClient*) = 0;

- // TODO(wjmaclean) Remove next two lines once https://codereview.chromium.org/23983047 lands.

- virtual void setMaxScrollPosition(WebSize) { }

- virtual void setScrollable(bool) { }

};

} // namespace blink

« no previous file with comments | « Source/web/PinchViewports.cpp ('k') | public/platform/WebScrollbarLayer.h » ('j') | public/platform/WebScrollbarLayer.h » ('J')