content/common/service_worker/embedded_worker_messages.h - Issue 139923005: Implement ServiceWorkerVersion::SendMessage() (for dispatching events etc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/embedded_worker_messages.h

Issue 139923005: Implement ServiceWorkerVersion::SendMessage() (for dispatching events etc) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/renderer/service_worker/embedded_worker_context_client.h » ('j') | content/renderer/service_worker/service_worker_script_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/embedded_worker_messages.h

diff --git a/content/common/service_worker/embedded_worker_messages.h b/content/common/service_worker/embedded_worker_messages.h

index d38e91f2e25c72c6b9e22afb23183a4caf1840ff..5367e68dbddf56122431768a7fae7d6db7d9dca8 100644

--- a/content/common/service_worker/embedded_worker_messages.h

+++ b/content/common/service_worker/embedded_worker_messages.h

@@ -36,8 +36,10 @@ IPC_MESSAGE_CONTROL1(EmbeddedWorkerHostMsg_WorkerStopped,

int /* embedded_worker_id */)

// Renderer ->Browser message to send message.

-IPC_MESSAGE_CONTROL2(EmbeddedWorkerHostMsg_SendMessageToBrowser,

+// |request_id| might be used for bi-directional messaging.

+IPC_MESSAGE_CONTROL3(EmbeddedWorkerHostMsg_SendMessageToBrowser,

int /* embedded_worker_id */,

+ int /* request_id */,

IPC::Message /* message */)

// ---------------------------------------------------------------------------

@@ -49,7 +51,9 @@ IPC_MESSAGE_CONTROL2(EmbeddedWorkerHostMsg_SendMessageToBrowser,

#define IPC_MESSAGE_START EmbeddedWorkerContextMsgStart

// Browser -> Renderer message to send message.

-IPC_MESSAGE_CONTROL3(EmbeddedWorkerContextMsg_SendMessageToWorker,

+// |request_id| might be used for bi-directional messaging.

+IPC_MESSAGE_CONTROL4(EmbeddedWorkerContextMsg_SendMessageToWorker,

int /* thread_id */,

int /* embedded_worker_id */,

+ int /* request_id */,

IPC::Message /* message */)