Issue 139923003: Fixed a few lifetime/ownership issues in cctest/test-api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139923003: Fixed a few lifetime/ownership issues in cctest/test-api. (Closed)

Created:
6 years, 10 months ago by Sven Panne

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed a few lifetime/ownership issues in cctest/test-api. * Fixed CompileExternalTwoByteSource: Registered resources should better still be alive when they are accessed. * Fixed ownership in cctest/test-api/VisitExternalStrings. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18971

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	test/cctest/cctest.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	4 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 10 months ago (2014-01-31 07:29:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18971 (presubmit successful).

Expand Messages | Collapse Messages