Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: src/gpu/GrClipMaskManager.h

Issue 1399223005: Don't abort analytic clipping if using MSAA until elements are examined (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrClipMaskManager.h
diff --git a/src/gpu/GrClipMaskManager.h b/src/gpu/GrClipMaskManager.h
index 90352f4621060eb42290bb9b50f4ff6ef2b41307..3ce3e72bf1c5c567ddbe25b2b48a7184d01604b6 100644
--- a/src/gpu/GrClipMaskManager.h
+++ b/src/gpu/GrClipMaskManager.h
@@ -89,8 +89,10 @@ private:
// Attempts to install a series of coverage effects to implement the clip. Return indicates
// whether the element list was successfully converted to processors. *fp may be nullptr even
// when the function succeeds because all the elements were ignored. TODO: Make clip reduction
- // bounds-aware and stop checking bounds in this function.
+ // bounds-aware and stop checking bounds in this function. Similarly, we shouldn't need to pass
+ // abortIfAA, but we don't yet know if all the AA elements will be eliminated.
bool getAnalyticClipProcessor(const GrReducedClip::ElementList&,
+ bool abortIfAA,
SkVector& clipOffset,
const SkRect* devBounds,
const GrFragmentProcessor** fp);
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698