Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1399223004: Add skia::ReadPixels() (Closed)

Created:
5 years, 2 months ago by tomhudson
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

80% of calls to skia::GetTopDevice() were retrieving a read-only reference to the raw pixel data; this CL simplifies those call sites and migrates to a more GPU-friendly and less internals-exposing implementation. BUG=543755 Committed: https://crrev.com/3c954e6fddda266a385a6ab076203eeba8290c24 Cr-Commit-Position: refs/heads/master@{#355104}

Patch Set 1 #

Patch Set 2 : Give up constness for modern peek/install/read idiom #

Patch Set 3 : Always copy pixels (consistent behavior) #

Patch Set 4 : Cast away some constness #

Patch Set 5 : Parentheses for the mac compiler #

Total comments: 4

Patch Set 6 : Extend comment #

Patch Set 7 : Switch to pointers because logical const isn't literal const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -44 lines) Patch
M chrome/browser/thumbnails/content_analysis_unittest.cc View 1 2 3 4 5 6 6 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/thumbnails/simple_thumbnail_crop_unittest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -10 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/color_analysis_unittest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -8 lines 0 comments Download
M ui/gfx/color_utils_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 33 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399223004/1
5 years, 2 months ago (2015-10-14 19:35:44 UTC) #2
Tom Hudson
Mike, (1) is the new code in platform_canvas.cc the correct modern idiom? (2) is something ...
5 years, 2 months ago (2015-10-14 20:02:00 UTC) #5
tomhudson
Mike suggested just calling canvas->readPixels(), always paying the copying overhead so that we have a ...
5 years, 2 months ago (2015-10-15 14:36:54 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399223004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399223004/40001
5 years, 2 months ago (2015-10-15 15:02:59 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/110475)
5 years, 2 months ago (2015-10-15 15:18:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399223004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399223004/60001
5 years, 2 months ago (2015-10-15 15:24:30 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/17128)
5 years, 2 months ago (2015-10-15 15:41:51 UTC) #14
Tom Hudson
Mike W, Jochen, git cl suggested you as OWNER-reviewers for this unit test refactoring. We ...
5 years, 2 months ago (2015-10-15 16:05:05 UTC) #16
msw
Can you seek review approval for the skia/* changes first? Also, please specify which parts ...
5 years, 2 months ago (2015-10-15 17:45:37 UTC) #17
reed1
skia/ext lgtm w/ suggestion/questions https://codereview.chromium.org/1399223004/diff/80001/skia/ext/platform_canvas.h File skia/ext/platform_canvas.h (right): https://codereview.chromium.org/1399223004/diff/80001/skia/ext/platform_canvas.h#newcode119 skia/ext/platform_canvas.h:119: // Copies pixels from the ...
5 years, 2 months ago (2015-10-15 18:13:15 UTC) #19
Tom Hudson
https://codereview.chromium.org/1399223004/diff/80001/skia/ext/platform_canvas.h File skia/ext/platform_canvas.h (right): https://codereview.chromium.org/1399223004/diff/80001/skia/ext/platform_canvas.h#newcode119 skia/ext/platform_canvas.h:119: // Copies pixels from the SkCanvas into an SkBitmap. ...
5 years, 2 months ago (2015-10-15 18:25:16 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399223004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399223004/120001
5 years, 2 months ago (2015-10-15 18:40:36 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 20:54:38 UTC) #24
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-20 10:01:11 UTC) #25
tomhudson
Thanks Jochen. Mike R, please review: ui/gfx/blit_unittest.cc ui/gfx/color_analysis_unittest.cc ui/gfx/color_utils_unittest.cc (I can't figure out from the ...
5 years, 2 months ago (2015-10-20 16:31:35 UTC) #26
tomhudson
On 2015/10/20 16:31:35, tomhudson wrote: > Mike R, please review: Sorry, that should be Mike ...
5 years, 2 months ago (2015-10-20 16:35:06 UTC) #27
msw
ui/gfx/* lgtm
5 years, 2 months ago (2015-10-20 16:59:14 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399223004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399223004/120001
5 years, 2 months ago (2015-10-20 17:04:15 UTC) #31
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 2 months ago (2015-10-20 18:12:19 UTC) #32
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:12:57 UTC) #33
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3c954e6fddda266a385a6ab076203eeba8290c24
Cr-Commit-Position: refs/heads/master@{#355104}

Powered by Google App Engine
This is Rietveld 408576698