Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1399223002: Add test for grapheme cluster fallback combined with unicode-range (Closed)

Created:
5 years, 2 months ago by drott
Modified:
5 years, 2 months ago
Reviewers:
eae, behdad
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for grapheme cluster fallback combined with unicode-range One of the failures related to grapheme cluster based font fallback and selection was reported in issue 454405. Let's start landing the changes for grapheme cluster based font selection and fallback, and shaper driven segmentation by adding a test case demonstrating the issue, combining font selection and unicode-range loading. BUG=454405 R=eae,behdad Committed: https://crrev.com/3e96338050230f22912c4e7daacd0e736177ac4d Cr-Commit-Position: refs/heads/master@{#353499}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
drott
5 years, 2 months ago (2015-10-12 09:14:25 UTC) #1
eae
LGTM++
5 years, 2 months ago (2015-10-12 09:16:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399223002/1
5 years, 2 months ago (2015-10-12 09:17:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 09:50:49 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 09:52:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e96338050230f22912c4e7daacd0e736177ac4d
Cr-Commit-Position: refs/heads/master@{#353499}

Powered by Google App Engine
This is Rietveld 408576698