Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 13992004: IpcSocketFactory pending packet limit is too small (Closed)

Created:
7 years, 8 months ago by Alpha Left Google
Modified:
7 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pwestin_googel.com, juberti2
Visibility:
Public.

Description

IpcSocketFactory pending packet limit is too small Refactoring is underway to notify client of P2P socket that network is congested. In the mean time pending packet limit is too small and causes huge amount of packet loss, this makes WebRTC unusable. This is a temporary fix to increase this pre-defined value to 32 pending packets which accomodates 720p streams up to 5Mb/s. BUG=228956, 229737 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/p2p/ipc_socket_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Alpha Left Google
7 years, 8 months ago (2013-04-10 01:26:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/13992004/1
7 years, 8 months ago (2013-04-10 01:27:47 UTC) #2
Sergey Ulanov
Why is this TBR?
7 years, 8 months ago (2013-04-10 01:29:09 UTC) #3
Alpha Left Google
Sure let's not TBR it. But we need to resolve this problem quickly as there's ...
7 years, 8 months ago (2013-04-10 01:30:51 UTC) #4
Sergey Ulanov
LBTM I don't see how the numbers in the description are connected. Did you test ...
7 years, 8 months ago (2013-04-10 01:35:46 UTC) #5
Alpha Left Google
Are we going to leave Canary broken? Ronghua's change is not going to land soon ...
7 years, 8 months ago (2013-04-10 01:41:50 UTC) #6
Sergey Ulanov
Ah, I see. If this is just a short-term solution until Ronghua's change lands, then ...
7 years, 8 months ago (2013-04-10 01:46:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/13992004/1
7 years, 8 months ago (2013-04-10 01:48:53 UTC) #8
Alpha Left Google
Yes this is to unbreak Chrome Canary. :) Next step is Ronghua's change will land ...
7 years, 8 months ago (2013-04-10 01:49:12 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101541
7 years, 8 months ago (2013-04-10 04:08:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/13992004/1
7 years, 8 months ago (2013-04-10 04:40:01 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101619
7 years, 8 months ago (2013-04-10 06:20:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/13992004/1
7 years, 8 months ago (2013-04-10 15:16:22 UTC) #13
Alpha Left Google
7 years, 8 months ago (2013-04-10 15:26:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 manually as r193389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698