Issue 1399133003: Make the check for calling super.created not sensitive to line delimiters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1399133003: Make the check for calling super.created not sensitive to line delimiters (Closed)

Created:
5 years, 2 months ago by Alan Knight

Modified:
5 years, 2 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make the check for calling super.created not sensitive to line delimiters BUG= Committed: https://github.com/dart-lang/sdk/commit/88b456d52972084790ca3afc5c29f5e8d82034ef

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	sdk/lib/html/dartium/html_dartium.dart	View		4 chunks	+6 lines, -8 lines	0 comments	Download
	M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View		3 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 3 (1 generated)

Alan Knight

TBR The hack to check for calling super.created splits by lines, and causes issues on ...

5 years, 2 months ago (2015-10-12 21:39:28 UTC) #2

Alan Knight

5 years, 2 months ago (2015-10-12 21:40:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
88b456d52972084790ca3afc5c29f5e8d82034ef (presubmit successful).