Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1399123002: [TextBlob] Fall back to TightRunBounds when the font bounds are empty (Closed)

Created:
5 years, 2 months ago by f(malita)
Modified:
5 years, 2 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[TextBlob] Fall back to TightRunBounds when the font bounds are empty Empty font bounds are likely an indication of a font bug. As a best effort, we can use TightRunBounds in this easily detectable case. Since TightRunBounds only supports kDefault_Positioning currently, the CL also reinstates handling of kFull_Positioning and kHorizontal_Positioning (removed in http://crrev.com/858153007). BUG=507022 R=reed@google.com,bungeman@google.com Committed: https://skia.googlesource.com/skia/+/b0b45d35e4f30c1f42b6a910dc7f90e1a88de70c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M src/core/SkTextBlob.cpp View 3 chunks +45 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399123002/1
5 years, 2 months ago (2015-10-09 20:31:21 UTC) #2
f(malita)
This is a respin of https://codereview.chromium.org/1284693002/, with TightRunBounds expanded to handle kFull_Positioning & kHorizontal_Positioning.
5 years, 2 months ago (2015-10-09 20:33:25 UTC) #3
bungeman-skia
lgtm
5 years, 2 months ago (2015-10-09 20:57:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-09 20:58:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399123002/1
5 years, 2 months ago (2015-10-09 21:45:47 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 21:46:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b0b45d35e4f30c1f42b6a910dc7f90e1a88de70c

Powered by Google App Engine
This is Rietveld 408576698