Commit InvalidationService implementations

chrome/browser/invalidation/invalidation_frontend.h

Index: chrome/browser/invalidation/invalidation_frontend.h
diff --git a/chrome/browser/sync/invalidation_frontend.h b/chrome/browser/invalidation/invalidation_frontend.h
similarity index 77%
rename from chrome/browser/sync/invalidation_frontend.h
rename to chrome/browser/invalidation/invalidation_frontend.h
index 0c767704f0b12fe0be6ad988e2f41a712aab6e27..2cfaf28d6f9fd17f8ff1c0640aa15479bb471b6a 100644
--- a/chrome/browser/sync/invalidation_frontend.h
+++ b/chrome/browser/invalidation/invalidation_frontend.h
@@ -2,15 +2,19 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_SYNC_INVALIDATION_FRONTEND_H_
-#define CHROME_BROWSER_SYNC_INVALIDATION_FRONTEND_H_
+#ifndef CHROME_BROWSER_INVALIDATION_INVALIDATION_FRONTEND_H_
+#define CHROME_BROWSER_INVALIDATION_INVALIDATION_FRONTEND_H_

[rlarocque, 2013/04/24 20:26:15]

Note: The next patch in the series will rename this from InvalidationFrontend to
InvalidationService.  I decided to keep the existing name for now because I
don't want to touch ProfileSyncService or any of the files that treat it as an
InvalidationFrontend in this CL.

 
 #include "sync/notifier/invalidation_util.h"
+#include "sync/notifier/invalidator_state.h"
 
 namespace syncer {
 class InvalidationHandler;
+class AckHandle;
 }  // namespace syncer
 
+namespace invalidation {
+
 // Interface for classes that handle invalidation registrations and send out
 // invalidations to register handlers.
 //
@@ -26,17 +30,8 @@ class InvalidationHandler;
 //
 //   frontend->UpdateRegisteredInvalidationIds(client_handler, client_ids);
 //
-// When shutting down the client for browser shutdown:
-//
-//   frontend->UnregisterInvalidationHandler(client_handler);
-//
-// Note that there's no call to UpdateRegisteredIds() -- this is because the
-// invalidation API persists registrations across browser restarts.
-//
-// When permanently shutting down the client, e.g. when disabling the related
-// feature:
+// To unregister for all invalidations:
 //
-//   frontend->UpdateRegisteredInvalidationIds(client_handler, ObjectIdSet());
 //   frontend->UnregisterInvalidationHandler(client_handler);
 //
 // If an invalidation handler cares about the invalidator state, it should also
@@ -47,11 +42,8 @@ class InvalidationHandler;
 // It can also do the above in OnInvalidatorStateChange(), or it can use the
 // argument to OnInvalidatorStateChange().
 //
-// It is an error to have registered handlers when an
-// InvalidationFrontend is shut down; clients must ensure that they
-// unregister themselves before then. (Depending on the
-// InvalidationFrontend, shutdown may be equivalent to destruction, or
-// a separate function call like Shutdown()).
+// It is an error to have registered handlers when an InvalidationFrontend is
+// shut down; clients must ensure that they unregister themselves before then.
 //
 // NOTE(akalin): Invalidations that come in during browser shutdown may get
 // dropped.  This won't matter once we have an Acknowledge API, though: see
@@ -96,4 +88,6 @@ class InvalidationFrontend {
   virtual ~InvalidationFrontend() { }
 };
 
-#endif  // CHROME_BROWSER_SYNC_INVALIDATION_FRONTEND_H_
+}  // namespace invalidation
+
+#endif  // CHROME_BROWSER_INVALIDATION_INVALIDATION_FRONTEND_H_