Issue 13991015: [Telemetry] Wait for pages to load completely during record_wpr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13991015: [Telemetry] Wait for pages to load completely during record_wpr. (Closed)

Created:
7 years, 8 months ago by tonyg

Modified:
7 years, 8 months ago

Reviewers:
dtu, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, marja

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Wait for pages to load completely during record_wpr. Previously we were only waiting for DOMContentLoaded instead of Load. BUG=None TEST=Recorded new page_sets on linux NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194472

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/telemetry/telemetry/page/record_wpr.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tonyg

On 2013/04/16 22:16:50, nduca wrote: > lgtm. that sleep feels fishy but whatevez. Yeah, the ...

7 years, 8 months ago (2013-04-16 22:40:00 UTC) #3

tonyg

7 years, 8 months ago (2013-04-16 22:43:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r194472 (presubmit successful).

Expand Messages | Collapse Messages